Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix seed resuming #1468

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

LZHgrla
Copy link
Contributor

@LZHgrla LZHgrla commented Jan 10, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers. By the way, if you're not familiar with how to use pre-commit to fix lint issues or add unit tests, please refer to Contributing to OpenMMLab.

Motivation

  1. The resuming of seed is too late

    For example, before the seed resuming, the dataloader and other parts have been constructed. In this situation, the sampler of dataloader uses the old seed, leading to inconsistent for resuming (especially for the iter-based training)

  2. IterBasedTrainLoop is not correct for resume

    The beginning data index is 0, instead of self._iter

Modification

Load the resumed checkpoint in the __init__ of runner, and resume the seed. This modification may seem foolish, but in my option, it is the most compatible way, especially for FlexibleRunner.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDetection or MMPretrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@LZHgrla LZHgrla changed the title [Fix] Fix seed resume [Fix] Fix seed resuming Jan 10, 2024
@LZHgrla LZHgrla changed the title [Fix] Fix seed resuming [WIP] [Fix] Fix seed resuming Jan 10, 2024
@LZHgrla LZHgrla marked this pull request as draft January 10, 2024 13:17
@LZHgrla LZHgrla changed the title [WIP] [Fix] Fix seed resuming [Fix] Fix seed resuming Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant